-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Remove production profiler from docs build #15959
Conversation
Deploy preview: https://deploy-preview-15959--material-ui-x.netlify.app/ |
Before: After: Drag the scrollbar up/down and verify that there's no flash of content anymore. It might be desirable to add the profiler to preview builds though, but this is to display the root cause of the issue. Could potentially affect #15681 as well. |
"build": "rimraf ./export && cross-env NODE_ENV=production next build --profile && pnpm build-sw", | ||
"build": "rimraf ./export && cross-env NODE_ENV=production next build && pnpm build-sw", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eps1lon initially added this flag in mui/material-ui#21975.
I'm making the connection as it seems that this started with upgrading Next.js 14.2.20 -> 15.1.1 #15144.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can I repro this? Would be helpful to get specifics here since profiling is currently in development so the earlier we find these issues, the better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compare the below – drag the scrollbar up and down to see the visible difference (flash of content with profiler vs. no flash without):
Fixes #15957 – production profiler adds overhead to rendering, which hurts performance. For whatever reason the performance impact is higher in next15, impacting scroll performance visibly.